-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add web-time #907
Add web-time #907
Conversation
It is failing the Also I wonder if it is possible to write tests for WASM... |
I'm not sure if I can write tests for WASM, but I'll try it. BTW, I have fixed the |
If we add |
Why is the wasm build failing without default features? |
Why did you change it to no_time instead? Before it is pulled in only for wasm which doesnt have |
You are correct. I have changed it to |
It shoudnt... no-std is not supposed to pull in web-time, then it shouldnt be affected. If it still fails that means web-time is still being brought in somehow... |
I'm pretty sure the issue is related to |
Is it possible that |
It's not supported to be pulled if I don't add features |
If only one dependency crate in the entire tree depends on |
It turn out that |
according to #891, since instant is no longer maintained, we should use web-time to replace it. Actually I have built WASM to make sure it works in it, but it seems that I don't find unit tests for WASM.